[rubygems/rubygems] Warn on duplicate dependency in a specification

rubygems/rubygems@af3e5f7883
ruby · Jul 31, 2020 · 00bdac1 · 00bdac1
1 parent 985309a
commit 00bdac1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/rubygems/specification.rb b/lib/rubygems/specification.rb
@@ -556,6 +556,10 @@ def add_development_dependency(gem, *requirements)
   #   spec.add_runtime_dependency 'example', '~> 1.1', '>= 1.1.4'
 
   def add_runtime_dependency(gem, *requirements)
+    if requirements.uniq.size != requirements.size
+      warn "WARNING: duplicate dependency #{requirements}"
+    end
+
     add_dependency_with_type(gem, :runtime, requirements)
   end
 

diff --git a/test/rubygems/test_gem_specification.rb b/test/rubygems/test_gem_specification.rb
@@ -3051,6 +3051,13 @@ def test_unresolved_specs_with_versions
     end
   end
 
+  def test_duplicate_runtime_dependency
+    expected = "WARNING: duplicate dependency [\"~> 3.0\", \"~> 3.0\"]\n"
+    assert_output nil, expected do
+      @a1.add_runtime_dependency "b", "~> 3.0", "~> 3.0"
+    end
+  end
+
   def set_orig(cls)
     s_cls = cls.singleton_class
     s_cls.send :alias_method, :orig_unresolved_deps , :unresolved_deps