Skip to content

Commit

Permalink
RBIMPL_ATTR_NOALIAS: not until LLVM 12
Browse files Browse the repository at this point in the history
I observed CI failures.
https://github.com/ruby/ruby/actions/runs/1240165911

It turns out that  RBIMPL_ATTR_NOALIAS was not mature before.  Skip
using it for old clang, and everything work as expected.
  • Loading branch information
shyouhei committed Sep 22, 2021
1 parent ecaf3a3 commit 0dea31c
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion include/ruby/internal/attr/noalias.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,21 @@
* that has to be passed to the function as a pointer. ::VALUE -taking
* functions thus cannot be attributed as such.
*/
#include "ruby/internal/compiler_since.h"
#include "ruby/internal/has/declspec_attribute.h"

/** Wraps (or simulates) `__declspec((noalias))` */
#if RBIMPL_HAS_DECLSPEC_ATTRIBUTE(noalias)
#if RBIMPL_COMPILER_BEFORE(Clang, 12, 0, 0)
# /*
# * `::llvm::Attribute::ArgMemOnly` was buggy before. Maybe because nobody
# * actually seriously used it. It seems they somehow mitigated the situation
# * in LLVM 12. Still not found the exact changeset which fiexed the
# * attribute, though.
# *
# * :FIXME: others (armclang, xlclang, ...) can also be affected?
# */
# define RBIMPL_ATTR_NOALIAS() /* void */
#elif RBIMPL_HAS_DECLSPEC_ATTRIBUTE(noalias)
# define RBIMPL_ATTR_NOALIAS() __declspec(noalias)
#else
# define RBIMPL_ATTR_NOALIAS() /* void */
Expand Down

0 comments on commit 0dea31c

Please sign in to comment.