[ruby/reline] Change Reline.add_dialog_proc(name, nil) to properly

remove dialog_proc (ruby/reline#532) ruby/reline@43283b2f37
ruby · Apr 15, 2023 · 19aa30d · 19aa30d
1 parent 34f484d
commit 19aa30d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/reline.rb b/lib/reline.rb
@@ -166,9 +166,13 @@ def dig_perfect_match_proc=(p)
 
     DialogProc = Struct.new(:dialog_proc, :context)
     def add_dialog_proc(name_sym, p, context = nil)
-      raise ArgumentError unless p.respond_to?(:call) or p.nil?
       raise ArgumentError unless name_sym.instance_of?(Symbol)
-      @dialog_proc_list[name_sym] = DialogProc.new(p, context)
+      if p.nil?
+        @dialog_proc_list.delete(name_sym)
+      else
+        raise ArgumentError unless p.respond_to?(:call)
+        @dialog_proc_list[name_sym] = DialogProc.new(p, context)
+      end
     end
 
     def dialog_proc(name_sym)

diff --git a/test/reline/test_reline.rb b/test/reline/test_reline.rb
@@ -321,6 +321,9 @@ def test_add_dialog_proc
     d = Reline.dialog_proc(:test_proc)
     assert_equal(dummy_proc_2, d.dialog_proc)
 
+    Reline.add_dialog_proc(:test_proc, nil)
+    assert_nil(Reline.dialog_proc(:test_proc))
+
     l = lambda {}
     Reline.add_dialog_proc(:test_lambda, l)
     d = Reline.dialog_proc(:test_lambda)