Skip to content

Commit

Permalink
[ruby/reline] Use gray and white as the default dialog theme
Browse files Browse the repository at this point in the history
(ruby/reline#637)

I think this has a few benefits:

1. Most terminal themes generally don't change or pick similar colors
   for their black and white colors, so it's more likely to be consistent
    across terminals/themes.
2. They don't have the potential color-blind issues that other color options
   may have.
3. We won't need additional changes for no color mode.

ruby/reline@6579a0a737
  • Loading branch information
st0012 authored and matzbot committed Feb 25, 2024
1 parent 7356067 commit 2721a64
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lib/reline/face.rb
Expand Up @@ -186,9 +186,9 @@ def self.load_initial_configs
conf.define :scrollbar, style: :reset
end
config(:completion_dialog) do |conf|
conf.define :default, foreground: :white, background: :cyan
conf.define :enhanced, foreground: :white, background: :magenta
conf.define :scrollbar, foreground: :white, background: :cyan
conf.define :default, foreground: :bright_white, background: :gray
conf.define :enhanced, foreground: :black, background: :white
conf.define :scrollbar, foreground: :white, background: :gray
end
end

Expand Down

0 comments on commit 2721a64

Please sign in to comment.