Skip to content

Commit

Permalink
ruby_vm_global_method_state is no longer needed.
Browse files Browse the repository at this point in the history
Now ruby_vm_global_method_state is not used so let's remove it.
  • Loading branch information
ko1 committed Oct 14, 2020
1 parent fad97f1 commit 278450d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 11 deletions.
4 changes: 2 additions & 2 deletions test/ruby/test_rubyvm.rb
Expand Up @@ -4,11 +4,11 @@
class TestRubyVM < Test::Unit::TestCase
def test_stat
assert_kind_of Hash, RubyVM.stat
assert_kind_of Integer, RubyVM.stat[:global_method_state]
assert_kind_of Integer, RubyVM.stat[:global_constant_state]

RubyVM.stat(stat = {})
assert_not_empty stat
assert_equal stat[:global_method_state], RubyVM.stat(:global_method_state)
assert_equal stat[:global_constant_state], RubyVM.stat(:global_constant_state)
end

def test_stat_unknown
Expand Down
8 changes: 2 additions & 6 deletions vm.c
Expand Up @@ -385,7 +385,6 @@ rb_event_flag_t ruby_vm_event_flags;
rb_event_flag_t ruby_vm_event_enabled_global_flags;
unsigned int ruby_vm_event_local_num;

rb_serial_t ruby_vm_global_method_state = 1;
rb_serial_t ruby_vm_global_constant_state = 1;
rb_serial_t ruby_vm_class_serial = 1;

Expand Down Expand Up @@ -456,7 +455,6 @@ rb_dtrace_setup(rb_execution_context_t *ec, VALUE klass, ID id,
* This hash includes information about method/constant cache serials:
*
* {
* :global_method_state=>251,
* :global_constant_state=>481,
* :class_serial=>9029
* }
Expand All @@ -470,7 +468,7 @@ rb_dtrace_setup(rb_execution_context_t *ec, VALUE klass, ID id,
static VALUE
vm_stat(int argc, VALUE *argv, VALUE self)
{
static VALUE sym_global_method_state, sym_global_constant_state, sym_class_serial;
static VALUE sym_global_constant_state, sym_class_serial;
VALUE arg = Qnil;
VALUE hash = Qnil, key = Qnil;

Expand All @@ -487,9 +485,8 @@ vm_stat(int argc, VALUE *argv, VALUE self)
hash = rb_hash_new();
}

if (sym_global_method_state == 0) {
if (sym_global_constant_state == 0) {
#define S(s) sym_##s = ID2SYM(rb_intern_const(#s))
S(global_method_state);
S(global_constant_state);
S(class_serial);
#undef S
Expand All @@ -501,7 +498,6 @@ vm_stat(int argc, VALUE *argv, VALUE self)
else if (hash != Qnil) \
rb_hash_aset(hash, sym_##name, SERIALT2NUM(attr));

SET(global_method_state, ruby_vm_global_method_state);
SET(global_constant_state, ruby_vm_global_constant_state);
SET(class_serial, ruby_vm_class_serial);
#undef SET
Expand Down
3 changes: 0 additions & 3 deletions vm_insnhelper.h
Expand Up @@ -14,7 +14,6 @@
RUBY_SYMBOL_EXPORT_BEGIN

RUBY_EXTERN VALUE ruby_vm_const_missing_count;
RUBY_EXTERN rb_serial_t ruby_vm_global_method_state;
RUBY_EXTERN rb_serial_t ruby_vm_global_constant_state;
RUBY_EXTERN rb_serial_t ruby_vm_class_serial;

Expand Down Expand Up @@ -178,8 +177,6 @@ CC_SET_FASTPATH(const struct rb_callcache *cc, vm_call_handler func, bool enable

#define PREV_CLASS_SERIAL() (ruby_vm_class_serial)
#define NEXT_CLASS_SERIAL() (++ruby_vm_class_serial)
#define GET_GLOBAL_METHOD_STATE() (ruby_vm_global_method_state)
#define INC_GLOBAL_METHOD_STATE() (++ruby_vm_global_method_state)
#define GET_GLOBAL_CONSTANT_STATE() (ruby_vm_global_constant_state)
#define INC_GLOBAL_CONSTANT_STATE() (++ruby_vm_global_constant_state)

Expand Down

0 comments on commit 278450d

Please sign in to comment.