Skip to content

Commit

Permalink
YJIT: Enable out of memory tests
Browse files Browse the repository at this point in the history
As of [1] and [2], YJIT has enough support for out of memory conditions
to pass these two basic tests.

OOM code paths are prone to bugs since they are rarely exercised in
common workloads. We might want to add CI runs that stress test these
code paths. Maybe outside of GitHub Actions for capacity reasons.

[1]: f41b4d4
[2]: b5b6ab4
  • Loading branch information
XrXr committed Dec 4, 2021
1 parent 4a6ca12 commit 34b5e25
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions bootstraptest/test_yjit.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2450,10 +2450,10 @@ def nimai(jita)
RubyVM::YJIT.simulate_oom! if defined?(RubyVM::YJIT)
nimai(false)
} if false # disabled for now since OOM crashes in the test harness
}

# block invalidation while out of memory
assert_equal 'new', %q{
# test block invalidation while out of memory
def foo
:old
end
Expand All @@ -2472,7 +2472,7 @@ def foo
end
test
} if false # disabled for now since OOM crashes in the test harness
}

assert_equal 'ok', %q{
# Try to compile new method while OOM
Expand Down

0 comments on commit 34b5e25

Please sign in to comment.