Skip to content

Commit

Permalink
Implements missing literals for defined?
Browse files Browse the repository at this point in the history
This PR implements the following literals:

- String
- Symbols
- Integers
- Floats
- Regexs
- Ranges
- Lambdas
- Hashes

and tests for them.
  • Loading branch information
eileencodes authored and tenderlove committed Dec 1, 2023
1 parent ee0eca1 commit 3923888
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
9 changes: 8 additions & 1 deletion prism_compile.c
Expand Up @@ -1465,9 +1465,16 @@ pm_compile_defined_expr0(rb_iseq_t *iseq, const pm_node_t *node, LINK_ANCHOR *co
ADD_INSNL(ret, &dummy_line_node, branchunless, lfinish[1]);
}
}
case PM_STRING_NODE:
case PM_AND_NODE:
case PM_FLOAT_NODE:
case PM_HASH_NODE:
case PM_INTEGER_NODE:
case PM_LAMBDA_NODE:
case PM_OR_NODE:
case PM_RANGE_NODE:
case PM_REGULAR_EXPRESSION_NODE:
case PM_STRING_NODE:
case PM_SYMBOL_NODE:
dtype = DEFINED_EXPR;
break;
case PM_LOCAL_VARIABLE_READ_NODE:
Expand Down
8 changes: 8 additions & 0 deletions test/ruby/test_compile_prism.rb
Expand Up @@ -95,8 +95,16 @@ def test_DefinedNode
assert_prism_eval("defined? self")
assert_prism_eval("defined? true")
assert_prism_eval("defined? false")
assert_prism_eval("defined? 1")
assert_prism_eval("defined? 1.0")
assert_prism_eval("defined? 1..2")
assert_prism_eval("defined? [A, B, C]")
assert_prism_eval("defined? [1, 2, 3]")
assert_prism_eval("defined?({ a: 1 })")
assert_prism_eval("defined? 'str'")
assert_prism_eval("defined? :sym")
assert_prism_eval("defined? /foo/")
assert_prism_eval("defined? -> { 1 + 1 }")
assert_prism_eval("defined? a && b")
assert_prism_eval("defined? a || b")

Expand Down

0 comments on commit 3923888

Please sign in to comment.