Fix the case trailer without newline

cf0b413
ruby · Dec 21, 2022 · 398aaed · 398aaed
1 parent 98fbebf
commit 398aaed
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/tool/sync_default_gems.rb b/tool/sync_default_gems.rb
@@ -466,13 +466,13 @@ def message_filter(repo, sha, input: ARGF)
     if log and !log.empty?
       log.sub!(/(?<=\n)\n+\z/, '') # drop empty lines at the last
       conv[log]
-      log.sub!(/(?:(\A\s*)|\s*\n)(?=((?i:Co-authored-by:.*\n)+)?\Z)/) {
+      log.sub!(/(?:(\A\s*)|\s*\n)(?=((?i:^Co-authored-by:.*\n?)+)?\Z)/) {
         ($~.begin(1) ? "" : "\n\n") + commit_url + ($~.begin(2) ? "\n" : "")
       }
     else
       log = commit_url
     end
-    print subject, "\n\n", log
+    puts subject, "\n", log
   end
 
   # NOTE: This method is also used by GitHub ruby/git.ruby-lang.org's bin/update-default-gem.sh

diff --git a/tool/test/test_sync_default_gems.rb b/tool/test/test_sync_default_gems.rb
@@ -62,5 +62,15 @@ def test_multiple_co_authored_by
       ]
       assert_message_filter(expected, trailers, [expected, "", trailers, ""].join("\n"))
     end
+
+    def test_co_authored_by_no_newline
+      expected = [
+        "commit something",
+      ]
+      trailers = [
+        "Co-Authored-By: git <git@ruby-lang.org>",
+      ]
+      assert_message_filter(expected, trailers, [expected, "", trailers].join("\n"))
+    end
   end
 end