Skip to content

Commit

Permalink
[rubygems/rubygems] Remove extension 'double pipe equals' assigment s…
Browse files Browse the repository at this point in the history
…ince is not needed anymore

rubygems/rubygems@930de86a24
  • Loading branch information
bronzdoc authored and hsbt committed Jul 30, 2019
1 parent b73ad49 commit 5824981
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions lib/rubygems/ext/builder.rb
Expand Up @@ -151,19 +151,6 @@ def build_error(output, backtrace = nil) # :nodoc:
def build_extension(extension, dest_path) # :nodoc:
results = []

# FIXME: Determine if this line is necessary and, if so, why.
# Notes:
# 1. As far as I can tell, this method is only called by +build_extensions+.
# 2. The existence of this line implies +extension+ is, or previously was,
# sometimes +false+ or +nil+.
# 3. #1 and #2 combined suggests, but does not confirm, that
# +@specs.extensions+ sometimes contained +false+ or +nil+ values.
# 4. Nothing seems to explicitly handle +extension+ being empty,
# which makes me wonder both what it should do and what it does.
#
# - @duckinator
extension ||= '' # I wish I knew why this line existed

builder = builder_for(extension)

extension_dir =
Expand Down

0 comments on commit 5824981

Please sign in to comment.