Skip to content

Commit

Permalink
[rubygems/rubygems] Change spec to do the right thing on bundler 3
Browse files Browse the repository at this point in the history
On bundler 3, the `--deployment` flag doesn't exist, so the `bundle
install --deployment` command was failing silently and the spec was
verifying a different scenario.

Change the spec to work the same regardless of bundler's major version.

Also, from the spec description it was not apparently that a specific
case involving deployment mode was being tested, so I reworded it to
make it more apparent.

rubygems/rubygems@3e33e2b927
  • Loading branch information
deivid-rodriguez authored and hsbt committed Jun 18, 2020
1 parent 974c40c commit 5d78fb1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions spec/bundler/runtime/setup_spec.rb
Expand Up @@ -279,13 +279,13 @@ def clean_load_path(lp)
end

context "an absolute path is not provided" do
it "uses BUNDLE_GEMFILE to locate the gemfile if present" do
it "uses BUNDLE_GEMFILE to locate the gemfile if present and doesn't fail in deployment mode" do
gemfile <<-G
source "#{file_uri_for(gem_repo1)}"
G

bundle "install"
bundle "install --deployment"
bundle "config set --local deployment true"

ENV["BUNDLE_GEMFILE"] = "Gemfile"
ruby <<-R
Expand Down

0 comments on commit 5d78fb1

Please sign in to comment.