Skip to content

Commit

Permalink
Fix Resolv specs to not depend on a system /etc/hosts file
Browse files Browse the repository at this point in the history
  • Loading branch information
eregon committed Jun 10, 2019
1 parent 614154b commit 60af6fe
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 15 deletions.
1 change: 1 addition & 0 deletions spec/ruby/library/resolv/fixtures/hosts
@@ -0,0 +1 @@
127.0.0.1 localhost localhost4
8 changes: 4 additions & 4 deletions spec/ruby/library/resolv/get_address_spec.rb
Expand Up @@ -4,11 +4,11 @@
describe "Resolv#getaddress" do
platform_is_not :windows do
it "resolves localhost" do
res = Resolv.new([Resolv::Hosts.new])
hosts = Resolv::Hosts.new(fixture(__FILE__ , "hosts"))
res = Resolv.new([hosts])

lambda {
res.getaddress("localhost")
}.should_not raise_error(Resolv::ResolvError)
res.getaddress("localhost").should == "127.0.0.1"
res.getaddress("localhost4").should == "127.0.0.1"
end
end

Expand Down
8 changes: 4 additions & 4 deletions spec/ruby/library/resolv/get_addresses_spec.rb
Expand Up @@ -4,11 +4,11 @@
describe "Resolv#getaddresses" do
platform_is_not :windows do
it "resolves localhost" do
res = Resolv.new([Resolv::Hosts.new])
hosts = Resolv::Hosts.new(fixture(__FILE__ , "hosts"))
res = Resolv.new([hosts])

addresses = res.getaddresses("localhost")
addresses.should_not == nil
addresses.size.should > 0
res.getaddresses("localhost").should == ["127.0.0.1"]
res.getaddresses("localhost4").should == ["127.0.0.1"]
end
end
end
7 changes: 4 additions & 3 deletions spec/ruby/library/resolv/get_name_spec.rb
Expand Up @@ -4,9 +4,10 @@
describe "Resolv#getname" do
platform_is_not :windows do
it "resolves 127.0.0.1" do
lambda {
Resolv.getname("127.0.0.1")
}.should_not raise_error(Resolv::ResolvError)
hosts = Resolv::Hosts.new(fixture(__FILE__ , "hosts"))
res = Resolv.new([hosts])

res.getname("127.0.0.1").should == "localhost"
end
end

Expand Down
7 changes: 3 additions & 4 deletions spec/ruby/library/resolv/get_names_spec.rb
Expand Up @@ -4,11 +4,10 @@
describe "Resolv#getnames" do
platform_is_not :windows do
it "resolves 127.0.0.1" do
res = Resolv.new([Resolv::Hosts.new])
hosts = Resolv::Hosts.new(fixture(__FILE__ , "hosts"))
res = Resolv.new([hosts])

names = res.getnames("127.0.0.1")
names.should_not == nil
names.size.should > 0
names = res.getnames("127.0.0.1").should == ["localhost", "localhost4"]
end
end
end

0 comments on commit 60af6fe

Please sign in to comment.