RJIT: Fix unwanted shadowing in set_local_type

local_idx should not be overwritten.
ruby · Dec 21, 2023 · 68bcca4 · 68bcca4
1 parent ffa5f16
commit 68bcca4
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/bootstraptest/test_rjit.rb b/bootstraptest/test_rjit.rb
@@ -42,3 +42,17 @@ def entry
 
   entry
 }
+
+# Updating local type in Context
+assert_normal_exit %q{
+  def foo(flag, object)
+    klass = if flag
+      object
+    end
+    klass ||= object
+    return klass.new
+  end
+
+  foo(false, Object)
+  foo(true, Object)
+}
diff --git a/lib/ruby_vm/rjit/context.rb b/lib/ruby_vm/rjit/context.rb
@@ -264,9 +264,9 @@ def set_local_type(local_idx, local_type)
           # noop
         in MapToSelf
           # noop
-        in MapToLocal[local_idx]
-          if stack_idx == local_idx
-            self.temp_types[stack_idx] = self.local_types[local_idx];
+        in MapToLocal[temp_local_idx]
+          if stack_idx == temp_local_idx
+            self.temp_types[stack_idx] = self.local_types[temp_local_idx]
             self.temp_mapping[stack_idx] = MapToStack
           else
             # noop