MiniTest::Unit.options has default :seed

MiniTest::Unit (superclass of Test::Unit::Runner) does not has default seed parameter, but assigned after initializing. However some tests use MiniTest::Unit without setup of seed option and it cases unexpected test failures. To solve this issue, add default seed parameter 42.
ruby · Feb 26, 2020 · 6b30638 · 6b30638
1 parent 14f1790
commit 6b30638
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/tool/lib/minitest/unit.rb b/tool/lib/minitest/unit.rb
@@ -763,7 +763,7 @@ class Unit # :nodoc:
     # Lazy accessor for options.
 
     def options
-      @options ||= {}
+      @options ||= {seed: 42}
     end
 
     @@installed_at_exit ||= false

diff --git a/tool/test/minitest/metametameta.rb b/tool/test/minitest/metametameta.rb
@@ -47,7 +47,6 @@ def setup
     srand 42
     MiniTest::Unit::TestCase.reset
     @tu = MiniTest::Unit.new
-    @tu.options[:seed] = 42
 
     MiniTest::Unit.runner = nil # protect the outer runner from the inner tests
   end