Skip to content

Commit

Permalink
Fix Symbol#inspect for GC compaction
Browse files Browse the repository at this point in the history
The test fails when RGENGC_CHECK_MODE is turned on:

    1) Failure:
    TestSymbol#test_inspect_under_gc_compact_stress [test/ruby/test_symbol.rb:123]:
    <":testing"> expected but was
    <":\x00\x00\x00\x00\x00\x00\x00">.
  • Loading branch information
peterzhu2118 committed Dec 25, 2023
1 parent e233730 commit 7002e77
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
7 changes: 6 additions & 1 deletion string.c
Expand Up @@ -11630,10 +11630,15 @@ sym_inspect(VALUE sym)
}
else {
rb_encoding *enc = STR_ENC_GET(str);
RSTRING_GETMEM(str, ptr, len);

VALUE orig_str = str;
RSTRING_GETMEM(orig_str, ptr, len);

str = rb_enc_str_new(0, len + 1, enc);
dest = RSTRING_PTR(str);
memcpy(dest + 1, ptr, len);

RB_GC_GUARD(orig_str);
}
dest[0] = ':';
return str;
Expand Down
6 changes: 6 additions & 0 deletions test/ruby/test_symbol.rb
Expand Up @@ -118,6 +118,12 @@ def test_inspect
end
end

def test_inspect_under_gc_compact_stress
EnvUtil.under_gc_compact_stress do
assert_inspect_evaled(':testing')
end
end

def test_name
assert_equal("foo", :foo.name)
assert_same(:foo.name, :foo.name)
Expand Down

0 comments on commit 7002e77

Please sign in to comment.