[ruby/io-console] Refined getch warnings

ruby/io-console@f84e6abcce
ruby · Oct 10, 2020 · 71428ac · 71428ac
1 parent 37259e8
commit 71428ac
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/ext/io/console/console.c b/ext/io/console/console.c
@@ -544,7 +544,7 @@ console_getch(int argc, VALUE *argv, VALUE io)
 	    if (optp->vtime) break;
 	    /* fallthru */
 	  default:
-	    rb_warning("min option ignored");
+	    rb_warning("min option larger than 1 ignored");
 	}
 	if (optp->intr) {
 # ifndef HAVE_RB_IO_WAIT
@@ -556,8 +556,8 @@ console_getch(int argc, VALUE *argv, VALUE io)
 	    if (result == Qfalse) return Qnil;
 # endif
 	}
-	else {
-	    rb_warning("vtime option ignored if intr flag is unset");
+	else if (optp->vtime) {
+	    rb_warning("Non-zero vtime option ignored if intr flag is unset");
 	}
     }
     len = (int)(VALUE)rb_thread_call_without_gvl(nogvl_getch, wbuf, RUBY_UBF_IO, 0);