Skip to content

Commit

Permalink
Make {Nil,True,False}Class#singleton_method always raise NameError
Browse files Browse the repository at this point in the history
{Nil,True,False}Class#singleton_methods always returns [] indicating
that there are no singleton methods defined, so #singleton_method
should be consistent with that.

Fixes [Bug #11064]
  • Loading branch information
jeremyevans committed Jul 26, 2023
1 parent 9b405a1 commit 786a864
Show file tree
Hide file tree
Showing 4 changed files with 48 additions and 4 deletions.
7 changes: 3 additions & 4 deletions proc.c
Expand Up @@ -2096,10 +2096,9 @@ rb_obj_singleton_method(VALUE obj, VALUE vid)
VALUE klass = rb_singleton_class_get(obj);
ID id = rb_check_id(&vid);

if (NIL_P(klass)) {
/* goto undef; */
}
else if (NIL_P(klass = RCLASS_ORIGIN(klass))) {
if (NIL_P(klass) ||
NIL_P(klass = RCLASS_ORIGIN(klass)) ||
!NIL_P(rb_special_singleton_class(obj))) {
/* goto undef; */
}
else if (! id) {
Expand Down
15 changes: 15 additions & 0 deletions spec/ruby/core/false/singleton_method_spec.rb
@@ -0,0 +1,15 @@
require_relative '../../spec_helper'

describe "FalseClass#singleton_method" do
ruby_version_is '3.3' do
it "raises regardless of whether FalseClass defines the method" do
proc{false.singleton_method(:foo)}.should raise_error(NameError)
begin
def false.foo; end
proc{false.singleton_method(:foo)}.should raise_error(NameError)
ensure
FalseClass.send(:remove_method, :foo)
end
end
end
end
15 changes: 15 additions & 0 deletions spec/ruby/core/nil/singleton_method_spec.rb
@@ -0,0 +1,15 @@
require_relative '../../spec_helper'

describe "NilClass#singleton_method" do
ruby_version_is '3.3' do
it "raises regardless of whether NilClass defines the method" do
proc{nil.singleton_method(:foo)}.should raise_error(NameError)
begin
def nil.foo; end
proc{nil.singleton_method(:foo)}.should raise_error(NameError)
ensure
NilClass.send(:remove_method, :foo)
end
end
end
end
15 changes: 15 additions & 0 deletions spec/ruby/core/true/singleton_method_spec.rb
@@ -0,0 +1,15 @@
require_relative '../../spec_helper'

describe "TrueClass#singleton_method" do
ruby_version_is '3.3' do
it "raises regardless of whether TrueClass defines the method" do
proc{true.singleton_method(:foo)}.should raise_error(NameError)
begin
def true.foo; end
proc{true.singleton_method(:foo)}.should raise_error(NameError)
ensure
TrueClass.send(:remove_method, :foo)
end
end
end
end

0 comments on commit 786a864

Please sign in to comment.