Exit with non-zero status on disabled gem system update.

ruby · Jun 15, 2020 · 7a57110 · 7a57110
1 parent 3ab1cfc
commit 7a57110
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/rubygems/commands/update_command.rb b/lib/rubygems/commands/update_command.rb
@@ -264,7 +264,7 @@ def update_gems(gems_to_update)
   def update_rubygems
     if Gem.disable_system_update_message
       alert_error Gem.disable_system_update_message
-      return
+      terminate_interaction 1
     end
 
     check_update_arguments

diff --git a/test/rubygems/test_gem_commands_update_command.rb b/test/rubygems/test_gem_commands_update_command.rb
@@ -245,8 +245,10 @@ def test_execute_system_with_disabled_update
     @cmd.options[:args] = []
     @cmd.options[:system] = true
 
-    use_ui @ui do
-      @cmd.execute
+    assert_raises Gem::MockGemUi::TermError do
+      use_ui @ui do
+        @cmd.execute
+      end
     end
 
     assert_empty @ui.output