Fix SEGV when ripper hits backref_error on command_asgn or arg

ruby · May 11, 2024 · 7e604a0 · 7e604a0
1 parent 68b6fe7
commit 7e604a0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/parse.y b/parse.y
@@ -3382,7 +3382,7 @@ command_asgn	: lhs '=' lex_ctxt command_rhs
                         rb_backref_error(p, $1);
                     /*% %*/
                         $$ = NEW_ERROR(&@$);
-                    /*% ripper[error]: backref_error(p, RNODE($:1), assign!(var_field(p, get_value($:1)), $:4)) %*/
+                    /*% ripper[error]: backref_error(p, $1, assign!(var_field(p, get_value($:1)), $:4)) %*/
                     }
                 ;
 
@@ -3981,7 +3981,7 @@ arg		: lhs '=' lex_ctxt arg_rhs
                     /*%%%*/
                         $$ = NEW_ERROR(&@$);
                     /*% %*/
-                    /*% ripper[error]: backref_error(p, RNODE($:1), opassign!(var_field(p, get_value($:1)), $:2, $:4)) %*/
+                    /*% ripper[error]: backref_error(p, $1, opassign!(var_field(p, get_value($:1)), $:2, $:4)) %*/
                     }
                 | arg tDOT2 arg
                     {

diff --git a/test/ripper/test_parser_events.rb b/test/ripper/test_parser_events.rb
@@ -278,6 +278,18 @@ def test_assign_error_backref
       parse('$`, _ = 1', :on_assign_error) {thru_assign_error = true}
     assert_equal true, thru_assign_error
     assert_equal '[massign([assign_error(var_field($`)),var_field(_)],1)]', result
+
+    thru_assign_error = false
+    result =
+      parse('$` += 1', :on_assign_error) {thru_assign_error = true}
+    assert_equal true, thru_assign_error
+    assert_equal '[assign_error(opassign(var_field($`),+=,1))]', result
+
+    thru_assign_error = false
+    result =
+      parse('$` += cmd 1, 2', :on_assign_error) {thru_assign_error = true}
+    assert_equal true, thru_assign_error
+    assert_equal '[assign_error(assign(var_field($`),command(cmd,[1,2])))]', result
   end
 
   def test_assign_error_const_qualified