Skip to content

Commit

Permalink
[Feature #20265] Remove rb_newobj and RB_NEWOBJ
Browse files Browse the repository at this point in the history
  • Loading branch information
peterzhu2118 committed Mar 14, 2024
1 parent 161545d commit 8e18314
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 31 deletions.
8 changes: 0 additions & 8 deletions gc.c
Expand Up @@ -2952,14 +2952,6 @@ rb_wb_protected_newobj_of(rb_execution_context_t *ec, VALUE klass, VALUE flags,
return newobj_of(rb_ec_ractor_ptr(ec), klass, flags, 0, 0, 0, TRUE, size);
}

/* for compatibility */

VALUE
rb_newobj(void)
{
return newobj_of(GET_RACTOR(), 0, T_NONE, 0, 0, 0, FALSE, RVALUE_SIZE);
}

VALUE
rb_newobj_of(VALUE klass, VALUE flags)
{
Expand Down
23 changes: 0 additions & 23 deletions include/ruby/internal/newobj.h
Expand Up @@ -29,21 +29,6 @@
#include "ruby/internal/value.h"
#include "ruby/assert.h"

/**
* Declares, allocates, then assigns a new object to the given variable.
*
* @param obj Variable name.
* @param type Variable type.
* @exception rb_eNoMemError No space left.
* @return An allocated object, not initialised.
* @note Modern programs tend to use #NEWOBJ_OF instead.
*
* @internal
*
* :FIXME: Should we deprecate it?
*/
#define RB_NEWOBJ(obj,type) type *(obj) = RBIMPL_CAST((type *)rb_newobj())

/**
* Identical to #RB_NEWOBJ, except it also accepts the allocating object's
* class and flags.
Expand All @@ -57,20 +42,12 @@
*/
#define RB_NEWOBJ_OF(obj,type,klass,flags) type *(obj) = RBIMPL_CAST((type *)rb_newobj_of(klass, flags))

#define NEWOBJ RB_NEWOBJ /**< @old{RB_NEWOBJ} */
#define NEWOBJ_OF RB_NEWOBJ_OF /**< @old{RB_NEWOBJ_OF} */
#define OBJSETUP rb_obj_setup /**< @old{rb_obj_setup} */
#define CLONESETUP rb_clone_setup /**< @old{rb_clone_setup} */
#define DUPSETUP rb_dup_setup /**< @old{rb_dup_setup} */

RBIMPL_SYMBOL_EXPORT_BEGIN()
/**
* This is the implementation detail of #RB_NEWOBJ.
*
* @exception rb_eNoMemError No space left.
* @return An allocated object, not initialised.
*/
VALUE rb_newobj(void);

/**
* This is the implementation detail of #RB_NEWOBJ_OF.
Expand Down

0 comments on commit 8e18314

Please sign in to comment.