Skip to content

Commit

Permalink
Update documentation for String#encode{,!} [ci skip]
Browse files Browse the repository at this point in the history
These methods take keywords, not a hash.

From tjschuck (T.J. Schuck)

Fixes [Bug #17364]
  • Loading branch information
jeremyevans committed Dec 3, 2020
1 parent 88bb1a6 commit 9195310
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions transcode.c
Expand Up @@ -2784,14 +2784,14 @@ str_encode_associate(VALUE str, int encidx)

/*
* call-seq:
* str.encode!(encoding [, options] ) -> str
* str.encode!(dst_encoding, src_encoding [, options] ) -> str
* str.encode!(encoding, **options) -> str
* str.encode!(dst_encoding, src_encoding, **options) -> str
*
* The first form transcodes the contents of <i>str</i> from
* str.encoding to +encoding+.
* The second form transcodes the contents of <i>str</i> from
* src_encoding to dst_encoding.
* The options Hash gives details for conversion. See String#encode
* The +options+ keyword arguments give details for conversion. See String#encode
* for details.
* Returns the string even if no changes were made.
*/
Expand Down Expand Up @@ -2820,9 +2820,9 @@ static VALUE encoded_dup(VALUE newstr, VALUE str, int encidx);

/*
* call-seq:
* str.encode(encoding [, options] ) -> str
* str.encode(dst_encoding, src_encoding [, options] ) -> str
* str.encode([options]) -> str
* str.encode(encoding, **options) -> str
* str.encode(dst_encoding, src_encoding, **options) -> str
* str.encode(**options) -> str
*
* The first form returns a copy of +str+ transcoded
* to encoding +encoding+.
Expand All @@ -2838,8 +2838,8 @@ static VALUE encoded_dup(VALUE newstr, VALUE str, int encidx);
* in the source encoding. The last form by default does not raise
* exceptions but uses replacement strings.
*
* The +options+ Hash gives details for conversion and can have the following
* keys:
* The +options+ keyword arguments give details for conversion.
* The arguments are:
*
* :invalid ::
* If the value is +:replace+, #encode replaces invalid byte sequences in
Expand Down

0 comments on commit 9195310

Please sign in to comment.