Skip to content

Commit

Permalink
[bundler/bundler] Deprecate --path flag to bundle check
Browse files Browse the repository at this point in the history
  • Loading branch information
deivid-rodriguez authored and hsbt committed Sep 18, 2019
1 parent 9118cb2 commit a29ead5
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/bundler/cli.rb
Expand Up @@ -156,6 +156,8 @@ def init
"Specify a different path than the system default ($BUNDLE_PATH or $GEM_HOME).#{" Bundler will remember this value for future installs on this machine" unless Bundler.feature_flag.forget_cli_options?}"
map "c" => "check"
def check
remembered_flag_deprecation("path")

require_relative "cli/check"
Check.new(options).run
end
Expand Down
22 changes: 22 additions & 0 deletions spec/bundler/other/major_deprecation_spec.rb
Expand Up @@ -95,6 +95,28 @@
end
end

context "bundle check --path" do
before do
install_gemfile <<-G
source "#{file_uri_for(gem_repo1)}"
gem "rack"
G

bundle "check --path vendor/bundle"
end

it "should print a deprecation warning", :bundler => "2" do
expect(deprecations).to include(
"The `--path` flag is deprecated because it relies on being " \
"remembered accross bundler invokations, which bundler will no " \
"longer do in future versions. Instead please use `bundle config set " \
"path 'vendor/bundle'`, and stop using this flag"
)
end

pending "should fail with a helpful error", :bundler => "3"
end

describe "bundle config" do
describe "old list interface" do
before do
Expand Down

0 comments on commit a29ead5

Please sign in to comment.