Skip to content

Commit

Permalink
[rubygems/rubygems] Remove broken test
Browse files Browse the repository at this point in the history
It turns out that this test is checking essentially nothing useful. The
paperclip gem doesn't exist in our setup, so initial install is failing
and the test is only checking that calling `bundle check` 3 times on a
broken setup always returns the same thing.

I went to the history of this test:

* rubygems/bundler@105654a
* rubygems/bundler@ae53be1
* rubygems/bundler@d19f4a7
* rubygems/bundler@092f169
* rubygems/bundler@3687843

And have finally decided to remove it since I'm not sure changing it to
something else will lead to testing something useful and not already
tested.

rubygems/rubygems@6184322967
  • Loading branch information
deivid-rodriguez authored and hsbt committed Jun 18, 2020
1 parent acd82bd commit a8f9a97
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions spec/bundler/commands/check_spec.rb
Expand Up @@ -210,21 +210,6 @@
expect(err).not_to include("Unfortunately, a fatal error has occurred. ")
end

it "should not crash when called multiple times on a new machine" do
gemfile <<-G
gem 'rails', '3.0.0.beta3'
gem 'paperclip', :git => 'git://github.com/thoughtbot/paperclip.git'
G

simulate_new_machine
bundle "check"
last_out = out
3.times do
bundle :check
expect(out).to eq(last_out)
end
end

it "fails when there's no lock file and frozen is set" do
install_gemfile! <<-G
source "#{file_uri_for(gem_repo1)}"
Expand Down

0 comments on commit a8f9a97

Please sign in to comment.