Skip to content

Commit

Permalink
Eliminate array allocation for f(*a, kw: 1, &lvar) and f(*a, kw: 1, &@Iv
Browse files Browse the repository at this point in the history
)

Similar to the previous commit, but this handles the block pass
case.
  • Loading branch information
jeremyevans committed Dec 7, 2023
1 parent 5e33f2b commit aa80820
Showing 1 changed file with 26 additions and 0 deletions.
26 changes: 26 additions & 0 deletions compile.c
Expand Up @@ -3940,6 +3940,32 @@ iseq_peephole_optimize(rb_iseq_t *iseq, LINK_ELEMENT *list, const int do_tailcal
OPERAND_AT(iobj, 0) = Qfalse;
}
}
else if (IS_NEXT_INSN_ID(niobj, getlocal) || IS_NEXT_INSN_ID(niobj, getinstancevariable)) {
niobj = niobj->next;

/*
* Eliminate array allocation for f(*a, kw: 1, &lvar) and f(*a, kw: 1, &@iv)
*
* splatarray true
* duphash
* getlocal / getinstancevariable
* send ARGS_SPLAT|KW_SPLAT|KW_SPLAT_MUT|ARGS_BLOCKARG
* =>
* splatarray false
* duphash
* getlocal / getinstancevariable
* send
*/
if (IS_NEXT_INSN_ID(niobj, send)) {
niobj = niobj->next;
unsigned int flag = vm_ci_flag((const struct rb_callinfo *)OPERAND_AT(niobj, 0));

if ((flag & VM_CALL_ARGS_SPLAT) && (flag & VM_CALL_KW_SPLAT) &&
(flag & VM_CALL_KW_SPLAT_MUT) && (flag & VM_CALL_ARGS_BLOCKARG)) {
OPERAND_AT(iobj, 0) = Qfalse;
}
}
}
}
}

Expand Down

0 comments on commit aa80820

Please sign in to comment.