[rubygems/rubygems] Make the "auto-user-install" logic easier to follow

rubygems/rubygems@4b4d9c0106
ruby · Dec 12, 2023 · b37288c · b37288c
1 parent c032dfb
commit b37288c
Showing 1 changed file with 13 additions and 9 deletions.
diff --git a/lib/rubygems/installer.rb b/lib/rubygems/installer.rb
@@ -675,16 +675,20 @@ def process_options # :nodoc:
 
     @build_args = options[:build_args]
 
-    @gem_home = @install_dir || Gem.dir
-
-    # `--build-root` overrides `--user-install` and auto-user-install
-    if @build_root.nil? && @install_dir.nil?
-      if options[:user_install]
-        @gem_home = Gem.user_dir
-      elsif !ENV.key?("GEM_HOME") && (File.exist?(Gem.dir) && !File.writable?(Gem.dir))
-        say "Defaulting to user installation because default installation directory (#{Gem.dir}) is not writable."
-        @gem_home = Gem.user_dir
+    @gem_home = @install_dir
+
+    unless @gem_home
+      # `--build-root` overrides `--user-install` and auto-user-install
+      if @build_root.nil?
+        if options[:user_install]
+          @gem_home = Gem.user_dir
+        elsif !ENV.key?("GEM_HOME") && (File.exist?(Gem.dir) && !File.writable?(Gem.dir))
+          say "Defaulting to user installation because default installation directory (#{Gem.dir}) is not writable."
+          @gem_home = Gem.user_dir
+        end
       end
+
+      @gem_home ||= Gem.dir
     end
 
     # If the user has asked for the gem to be installed in a directory that is