Skip to content

Commit

Permalink
[rubygems/rubygems] Use double-quotes instead of single-quotes in war…
Browse files Browse the repository at this point in the history
  • Loading branch information
hsbt committed Mar 28, 2023
1 parent 9cfd833 commit cd4b4ac
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
10 changes: 5 additions & 5 deletions lib/rubygems/specification_policy.rb
Expand Up @@ -162,7 +162,7 @@ def validate_duplicate_dependencies # :nodoc:
if prev = seen[dep.type][dep.name]
error_messages << <<-MESSAGE
duplicate dependency on #{dep}, (#{prev.requirement}) use:
add_#{dep.type}_dependency '#{dep.name}', '#{dep.requirement}', '#{prev.requirement}'
add_#{dep.type}_dependency \"#{dep.name}\", \"#{dep.requirement}\", \"#{prev.requirement}\"
MESSAGE
end

Expand Down Expand Up @@ -205,16 +205,16 @@ def validate_dependencies # :nodoc:
base = segments.first 2

recommendation = if [">", ">="].include?(op) && segments == [0]
" use a bounded requirement, such as '~> x.y'"
" use a bounded requirement, such as \"~> x.y\""
else
bugfix = if op == ">"
", '> #{dep_version}'"
", \"> #{dep_version}\""
elsif op == ">=" && base != segments
", '>= #{dep_version}'"
", \">= #{dep_version}\""
end

" if #{dep.name} is semantically versioned, use:\n" \
" add_#{dep.type}_dependency '#{dep.name}', '~> #{base.join "."}'#{bugfix}"
" add_#{dep.type}_dependency \"#{dep.name}\", \"~> #{base.join "."}\"#{bugfix}"
end

warning_messages << ["open-ended dependency on #{dep} is not recommended", recommendation].join("\n") + "\n"
Expand Down
14 changes: 7 additions & 7 deletions test/rubygems/test_gem_specification.rb
Expand Up @@ -2610,18 +2610,18 @@ def test_validate_dependencies
#{w}: prerelease dependency on c (>= 2.0.rc2, development) is not recommended
#{w}: open-ended dependency on i (>= 1.2) is not recommended
if i is semantically versioned, use:
add_runtime_dependency 'i', '~> 1.2'
add_runtime_dependency "i", "~> 1.2"
#{w}: open-ended dependency on j (>= 1.2.3) is not recommended
if j is semantically versioned, use:
add_runtime_dependency 'j', '~> 1.2', '>= 1.2.3'
add_runtime_dependency "j", "~> 1.2", ">= 1.2.3"
#{w}: open-ended dependency on k (> 1.2) is not recommended
if k is semantically versioned, use:
add_runtime_dependency 'k', '~> 1.2', '> 1.2'
add_runtime_dependency "k", "~> 1.2", "> 1.2"
#{w}: open-ended dependency on l (> 1.2.3) is not recommended
if l is semantically versioned, use:
add_runtime_dependency 'l', '~> 1.2', '> 1.2.3'
add_runtime_dependency "l", "~> 1.2", "> 1.2.3"
#{w}: open-ended dependency on o (>= 0) is not recommended
use a bounded requirement, such as '~> x.y'
use a bounded requirement, such as "~> x.y"
#{w}: See https://guides.rubygems.org/specification-reference/ for help
EXPECTED

Expand All @@ -2645,9 +2645,9 @@ def test_validate_dependencies_duplicates

expected = <<-EXPECTED
duplicate dependency on b (>= 1.2.3), (~> 1.2) use:
add_runtime_dependency 'b', '>= 1.2.3', '~> 1.2'
add_runtime_dependency "b", ">= 1.2.3", "~> 1.2"
duplicate dependency on c (>= 1.2.3, development), (~> 1.2) use:
add_development_dependency 'c', '>= 1.2.3', '~> 1.2'
add_development_dependency "c", ">= 1.2.3", "~> 1.2"
EXPECTED

assert_equal expected, e.message
Expand Down

0 comments on commit cd4b4ac

Please sign in to comment.