[ruby/reline] Properly restore Reline::IOGate in test teardown

(ruby/reline#593) * Properly restore Reline::IOGate in test teardown * GeneralIO.reset should reset class variable existence ruby/reline@c16d33dae5
ruby · Sep 28, 2023 · d494254 · d494254
1 parent 20c561f
commit d494254
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 13 deletions.
diff --git a/lib/reline/general_io.rb b/lib/reline/general_io.rb
@@ -3,7 +3,11 @@
 class Reline::GeneralIO
   def self.reset(encoding: nil)
     @@pasting = false
-    @@encoding = encoding
+    if encoding
+      @@encoding = encoding
+    elsif defined?(@@encoding)
+      remove_class_variable(:@@encoding)
+    end
   end
 
   def self.encoding

diff --git a/test/reline/helper.rb b/test/reline/helper.rb
@@ -21,21 +21,23 @@
 module Reline
   class <<self
     def test_mode(ansi: false)
-        remove_const('IOGate') if const_defined?('IOGate')
-        const_set('IOGate', ansi ? Reline::ANSI : Reline::GeneralIO)
-        if ENV['RELINE_TEST_ENCODING']
-          encoding = Encoding.find(ENV['RELINE_TEST_ENCODING'])
-        else
-          encoding = Encoding::UTF_8
-        end
-        Reline::GeneralIO.reset(encoding: encoding) unless ansi
-        core.config.instance_variable_set(:@test_mode, true)
-        core.config.reset
+      @original_iogate = IOGate
+      remove_const('IOGate')
+      const_set('IOGate', ansi ? Reline::ANSI : Reline::GeneralIO)
+      if ENV['RELINE_TEST_ENCODING']
+        encoding = Encoding.find(ENV['RELINE_TEST_ENCODING'])
+      else
+        encoding = Encoding::UTF_8
+      end
+      Reline::GeneralIO.reset(encoding: encoding) unless ansi
+      core.config.instance_variable_set(:@test_mode, true)
+      core.config.reset
     end
 
     def test_reset
-      remove_const('IOGate') if const_defined?('IOGate')
-      const_set('IOGate', Reline::GeneralIO)
+      remove_const('IOGate')
+      const_set('IOGate', @original_iogate)
+      Reline::GeneralIO.reset
       Reline.instance_variable_set(:@core, nil)
     end
 

diff --git a/test/reline/test_reline_key.rb b/test/reline/test_reline_key.rb
@@ -3,6 +3,7 @@
 
 class Reline::TestKey < Reline::TestCase
   def setup
+    Reline.test_mode
   end
 
   def teardown