Skip to content

Commit

Permalink
Merge bundler-2.1.1 from bundler/bundler
Browse files Browse the repository at this point in the history
  • Loading branch information
hsbt committed Dec 18, 2019
1 parent fa7fa5c commit efbc0d4
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 13 deletions.
15 changes: 3 additions & 12 deletions lib/bundler/cli/exec.rb
Expand Up @@ -25,12 +25,12 @@ def run
SharedHelpers.set_bundle_environment
if bin_path = Bundler.which(cmd)
if !Bundler.settings[:disable_exec_load] && ruby_shebang?(bin_path)
return with_verbose_rubygems { kernel_load(bin_path, *args) }
return kernel_load(bin_path, *args)
end
with_verbose_rubygems { kernel_exec(bin_path, *args) }
kernel_exec(bin_path, *args)
else
# exec using the given command
with_verbose_rubygems { kernel_exec(cmd, *args) }
kernel_exec(cmd, *args)
end
end

Expand Down Expand Up @@ -89,14 +89,5 @@ def ruby_shebang?(file)
first_line = File.open(file, "rb") {|f| f.read(possibilities.map(&:size).max) }
possibilities.any? {|shebang| first_line.start_with?(shebang) }
end

def with_verbose_rubygems
old_ui = Gem::DefaultUserInteraction.ui
Gem::DefaultUserInteraction.ui = nil

yield
ensure
Gem::DefaultUserInteraction.ui = old_ui
end
end
end
8 changes: 8 additions & 0 deletions lib/bundler/rubygems_integration.rb
Expand Up @@ -525,6 +525,14 @@ def stub_rubygems(specs)
end
end

def plain_specs
Gem::Specification._all
end

def plain_specs=(specs)
Gem::Specification.all = specs
end

def fetch_specs(remote, name)
path = remote.uri.to_s + "#{name}.#{Gem.marshal_version}.gz"
fetcher = gem_remote_fetcher
Expand Down
5 changes: 5 additions & 0 deletions lib/bundler/setup.rb
Expand Up @@ -19,4 +19,9 @@
else
Bundler.ui.silence { Bundler.setup }
end

# We might be in the middle of shelling out to rubygems
# (RUBYOPT=-rbundler/setup), so we need to give rubygems the opportunity of
# not being silent.
Gem::DefaultUserInteraction.ui = nil
end
2 changes: 1 addition & 1 deletion lib/bundler/version.rb
@@ -1,7 +1,7 @@
# frozen_string_literal: false

module Bundler
VERSION = "2.1.0".freeze
VERSION = "2.1.1".freeze

def self.bundler_major_version
@bundler_major_version ||= VERSION.split(".").first.to_i
Expand Down
6 changes: 6 additions & 0 deletions spec/bundler/commands/exec_spec.rb
Expand Up @@ -61,6 +61,12 @@
expect(out).to eq(Gem::VERSION)
end

it "works when exec'ing to rubygems through sh -c" do
install_gemfile 'gem "rack"'
bundle "exec sh -c '#{gem_cmd} --version'"
expect(out).to eq(Gem::VERSION)
end

it "respects custom process title when loading through ruby" do
script_that_changes_its_own_title_and_checks_if_picked_up_by_ps_unix_utility = <<~'RUBY'
Process.setproctitle("1-2-3-4-5-6-7-8-9-10-11-12-13-14-15")
Expand Down

0 comments on commit efbc0d4

Please sign in to comment.