Skip to content

Commit

Permalink
[rubygems/rubygems] Keep Gem.install_extension_in_lib for compatibility
Browse files Browse the repository at this point in the history
  • Loading branch information
hsbt authored and matzbot committed Feb 20, 2024
1 parent f2d4533 commit f75b9db
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 2 deletions.
1 change: 1 addition & 0 deletions lib/rubygems/config_file.rb
Expand Up @@ -47,6 +47,7 @@ class Gem::ConfigFile
DEFAULT_CONCURRENT_DOWNLOADS = 8
DEFAULT_CERT_EXPIRATION_LENGTH_DAYS = 365
DEFAULT_IPV4_FALLBACK_ENABLED = false
# TODO: Use false as default value for this option in RubyGems 4.0
DEFAULT_INSTALL_EXTENSION_IN_LIB = true

##
Expand Down
7 changes: 7 additions & 0 deletions lib/rubygems/defaults.rb
Expand Up @@ -247,6 +247,13 @@ def self.default_user_install # :nodoc:
false
end

##
# Install extensions into lib as well as into the extension directory.

def self.install_extension_in_lib # :nodoc:
Gem.configuration.install_extension_in_lib
end

##
# Directory where vendor gems are installed.

Expand Down
2 changes: 1 addition & 1 deletion lib/rubygems/ext/cargo_builder.rb
Expand Up @@ -47,7 +47,7 @@ def build(extension, dest_path, results, args = [], lib_dir = nil, cargo_dir = D

nesting = extension_nesting(extension)

if Gem.configuration.install_extension_in_lib && lib_dir
if Gem.install_extension_in_lib && lib_dir
nested_lib_dir = File.join(lib_dir, nesting)
FileUtils.mkdir_p nested_lib_dir
FileUtils.cp_r dlext_path, nested_lib_dir, remove_destination: true
Expand Down
2 changes: 1 addition & 1 deletion lib/rubygems/ext/ext_conf_builder.rb
Expand Up @@ -43,7 +43,7 @@ def self.build(extension, dest_path, results, args=[], lib_dir=nil, extension_di

full_tmp_dest = File.join(extension_dir, tmp_dest_relative)

if Gem.configuration.install_extension_in_lib && lib_dir
if Gem.install_extension_in_lib && lib_dir
FileUtils.mkdir_p lib_dir
entries = Dir.entries(full_tmp_dest) - %w[. ..]
entries = entries.map {|entry| File.join full_tmp_dest, entry }
Expand Down

0 comments on commit f75b9db

Please sign in to comment.