Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinGW on Actions #2791

Merged
merged 4 commits into from Dec 31, 2019
Merged

MinGW on Actions #2791

merged 4 commits into from Dec 31, 2019

Conversation

MSP-Greg
Copy link
Contributor

Starter yaml file for running MinGW builds on Actions.

  1. actions/checkout@v2 has been released with more options, etc. Changed to allow CI in forks when not using master branch.

  2. make build and make test seem to consistently succeed/pass.

  3. make test-all seems to have one or two consistent errors.

  4. make test-spec is kind of a mess. The 2nd commit is needed to bypass a spec, otherwise the step freezes. See Perform full MSYS2/MinGW update for build, -fstack-protector-strong - spec freeze #2718 and https://bugs.ruby-lang.org/issues/16265. But, with that change, the last run in my fork showed '58 failures, 2 errors'

  5. Since actions/setup-ruby@v1/disk images are not current, this uses an action of mine (MSP-Greg/actions-ruby@master) that install currents MinGW Rubies, corrects/cleans the Actions path, and allows package installation on the MSYS2 install.

With most of these issues not happening in AppVeyor CI, I haven't had time to look for why the CI platform is affecting things.

@MSP-Greg
Copy link
Contributor Author

make test-all seems to have one or two consistent errors.

It ran three times in my fork as above. Now it's frozen.

To any that have access, feel free to stop it:
https://github.com/ruby/ruby/pull/2791/checks?check_run_id=366378592

@MSP-Greg
Copy link
Contributor Author

MSP-Greg commented Dec 30, 2019

Rebased and pushed updated code. One spec and one test (test-all) were bypassed via the first two commits.

One issue that may help in mswin CI is that Actions Windows is changing line endings in the repo...

  1. test-all is still intermittently failing/freezing, but otherwise it passes with the one additional skip. Note that I've had a similar skip in ruby-loco for a while, and the problem does not exist when run locally.

  2. Had some odd test-spec issues, and decided to run it from install (as I do in ruby-loco). Problems cleared up, and it is stable.

  3. Added test timeouts.

I started on this for two reasons. First, AppVeyor CI often backs up all of the Ruby repos, and secondly, I expect to move ruby-loco to Actions, and likely similar issues...

EDIT: MinGW Actions passed here and also in my fork at:
https://github.com/MSP-Greg/ruby/runs/367310657

@MSP-Greg MSP-Greg marked this pull request as ready for review December 30, 2019 22:53
C-API Thread function rb_thread_call_without_gvl
      -- runs a C function with the global lock unlocked and unlocks IO with the generic RUBY_UBF_IO

stops/freezes spec tests

See https://bugs.ruby-lang.org/issues/16265
Test times out in CI (both AppVeyor & Actions), cannot repo locally
@k0kubun
Copy link
Member

k0kubun commented Dec 31, 2019

While we have some new skips on Actions compared to AppVeyor, people seem to basically agree that Actions is better than AppVeyor. Besides build time is shorter in Actions.

Let me merge this and drop AppVeyor MinGW. Thank you.

@k0kubun k0kubun merged commit eb2b425 into ruby:master Dec 31, 2019
matzbot pushed a commit that referenced this pull request Dec 31, 2019
@MSP-Greg MSP-Greg deleted the actions-mingw branch December 31, 2019 19:14
nurse pushed a commit to nurse/ruby that referenced this pull request Jan 30, 2020
* MinGW - skip spec in spec/ruby/optional/capi/thread_spec.rb

C-API Thread function rb_thread_call_without_gvl
      -- runs a C function with the global lock unlocked and unlocks IO with the generic RUBY_UBF_IO

stops/freezes spec tests

See https://bugs.ruby-lang.org/issues/16265

* MinGW - skip test test/resolv/test_dns.rb

Test times out in CI (both AppVeyor & Actions), cannot repo locally

* MinGW - skip test test/ruby/test_thread_queue.rb

* Add Actions mingw.yml
nurse pushed a commit to nurse/ruby that referenced this pull request Mar 14, 2020
in favor of ruby#2791

(cherry picked from commit b004187)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants