New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MinGW on Actions #2791
MinGW on Actions #2791
Conversation
It ran three times in my fork as above. Now it's frozen. To any that have access, feel free to stop it: |
75bdb0c
to
6101fec
Compare
Rebased and pushed updated code. One spec and one test (test-all) were bypassed via the first two commits. One issue that may help in mswin CI is that Actions Windows is changing line endings in the repo...
I started on this for two reasons. First, AppVeyor CI often backs up all of the Ruby repos, and secondly, I expect to move ruby-loco to Actions, and likely similar issues... EDIT: MinGW Actions passed here and also in my fork at: |
6101fec
to
66f2596
Compare
C-API Thread function rb_thread_call_without_gvl -- runs a C function with the global lock unlocked and unlocks IO with the generic RUBY_UBF_IO stops/freezes spec tests See https://bugs.ruby-lang.org/issues/16265
Test times out in CI (both AppVeyor & Actions), cannot repo locally
66f2596
to
4f1147e
Compare
While we have some new skips on Actions compared to AppVeyor, people seem to basically agree that Actions is better than AppVeyor. Besides build time is shorter in Actions. Let me merge this and drop AppVeyor MinGW. Thank you. |
* MinGW - skip spec in spec/ruby/optional/capi/thread_spec.rb C-API Thread function rb_thread_call_without_gvl -- runs a C function with the global lock unlocked and unlocks IO with the generic RUBY_UBF_IO stops/freezes spec tests See https://bugs.ruby-lang.org/issues/16265 * MinGW - skip test test/resolv/test_dns.rb Test times out in CI (both AppVeyor & Actions), cannot repo locally * MinGW - skip test test/ruby/test_thread_queue.rb * Add Actions mingw.yml
Starter yaml file for running MinGW builds on Actions.
actions/checkout@v2
has been released with more options, etc. Changed to allow CI in forks when not using master branch.make build
andmake test
seem to consistently succeed/pass.make test-all
seems to have one or two consistent errors.make test-spec
is kind of a mess. The 2nd commit is needed to bypass a spec, otherwise the step freezes. See Perform full MSYS2/MinGW update for build, -fstack-protector-strong - spec freeze #2718 and https://bugs.ruby-lang.org/issues/16265. But, with that change, the last run in my fork showed '58 failures, 2 errors'Since
actions/setup-ruby@v1
/disk images are not current, this uses an action of mine (MSP-Greg/actions-ruby@master
) that install currents MinGW Rubies, corrects/cleans the Actions path, and allows package installation on the MSYS2 install.With most of these issues not happening in AppVeyor CI, I haven't had time to look for why the CI platform is affecting things.