Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions mingw - add tool/test for WEBrick in spec tests #3882

Merged
merged 1 commit into from Dec 10, 2020

Conversation

MSP-Greg
Copy link
Contributor

Some spec tests require WEBrick, and the spec tests are run from install with the MinGW CI.

Some spec tests require WEBrick, and the spec tests are run from install with the MinGW CI.
@k0kubun k0kubun merged commit 4a559aa into ruby:master Dec 10, 2020
@k0kubun
Copy link
Member

k0kubun commented Dec 10, 2020

I agree this fixes the issue, but the real problem is that .github/workflows/mingw.yml is not using make test-spec, which leads this kind of individual fix. Could you check if we can replace ruby ../mspec/bin/mspec -j (since #2791) with make test-spec?

@MSP-Greg
Copy link
Contributor Author

Yes, it might be a few hours.

Since there is little testing of the install, I thought doing so for spec tests might be helpful. Then again, when it breaks (which has been rare), the cause may not be clear...

@MSP-Greg
Copy link
Contributor Author

MSP-Greg commented Dec 10, 2020

I hate December. This passed in my fork, so something has changed. I'll review. Thanks.

EDIT: wrong folder. Must be losing my mind...

@MSP-Greg
Copy link
Contributor Author

@k0kubun

Will test make test-spec shortly in my fork. Ruby-loco tests install folder (both mingw & mswin), so no need to do so here...

@k0kubun
Copy link
Member

k0kubun commented Dec 10, 2020

Ruby-loco tests install folder (both mingw & mswin), so no need to do so here...

👍

@MSP-Greg
Copy link
Contributor Author

@k0kubun

I ran CI in my fork using make test-spec and had one failure:

An exception occurred during: loading D:/a/ruby/ruby/src/spec/ruby/optional/capi/rbasic_spec.rb ERROR
Errno::ENOENT: No such file or directory @ rb_file_s_mtime - /install/bin/x64-msvcrt-ruby300.dll
D:/a/ruby/ruby/src/spec/ruby/optional/capi/spec_helper.rb:49:in `mtime'
D:/a/ruby/ruby/src/spec/ruby/optional/capi/spec_helper.rb:49:in `compile_extension'
D:/a/ruby/ruby/src/spec/ruby/optional/capi/spec_helper.rb:129:in `load_extension'
D:/a/ruby/ruby/src/spec/ruby/optional/capi/rbasic_spec.rb:4:in `<top (required)>'

Maybe due to the folder layout used for src, build, & install. Took a break, now using the equivalent of:

ruby ../mspec/bin/mspec -j -I../../tool/lib

Both ruby-loco builds passed with that. I think the -I placement in 'Fix the path properly' is incorrect.

Again, I apologize for the folder error...

@k0kubun
Copy link
Member

k0kubun commented Dec 10, 2020

Maybe we can fix the broken spec separately. Could you file the current make test-spec (+ a guard for skipping it) change first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants