Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include a backtick in error messages and backtraces #9608

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

mame
Copy link
Member

@mame mame commented Jan 19, 2024

[Feature #16495]

TODO:

  • Need to update prism's error messages.
  • Need to fix ruby/spec too.
  • By changing keyword display name from `true' to 'true', Lrama adds unneeded double quotes. @yui-knk fixed
$ ./miniruby -e 'def foo(true)'
-e:1: syntax error, unexpected "'true'", expecting ')'
def foo(true)
-e: compile error (SyntaxError)

$ ./miniruby -e 'foo(1 rescue 2)'
-e:1: syntax error, unexpected "'rescue' modifier", expecting ')'
foo(1 rescue 2)
-e: compile error (SyntaxError)

@mame mame force-pushed the no-backtick branch 2 times, most recently from e2dd20b to 160ec17 Compare January 19, 2024 07:37
@mame mame force-pushed the no-backtick branch 11 times, most recently from 9eb20e5 to 38aa03c Compare February 15, 2024 08:33
@mame mame marked this pull request as ready for review February 15, 2024 08:33
@mame mame enabled auto-merge (rebase) February 15, 2024 09:15
@mame mame merged commit 92eab38 into ruby:master Feb 15, 2024
100 of 101 checks passed
@mame mame deleted the no-backtick branch February 15, 2024 09:51
st0012 added a commit to getsentry/sentry-ruby that referenced this pull request Feb 21, 2024
In Ruby 3.4, the backtrace format has changed slightly. This commit
updates the regular expression used to parse the backtrace to support
Ruby 3.4.

See ruby/ruby#9608 for more information.
st0012 added a commit to getsentry/sentry-ruby that referenced this pull request Feb 21, 2024
In Ruby 3.4, the backtrace format has changed slightly. This commit
updates the regular expression used to parse the backtrace to support
Ruby 3.4.

See ruby/ruby#9608 for more information.
st0012 added a commit to getsentry/sentry-ruby that referenced this pull request Feb 21, 2024
* Update backtrace parsing regexp to support Ruby 3.4

In Ruby 3.4, the backtrace format has changed slightly. This commit
updates the regular expression used to parse the backtrace to support
Ruby 3.4.

See ruby/ruby#9608 for more information.

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant