Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use '\n'? instead of opt_nl #10051

Merged
merged 1 commit into from Feb 26, 2024
Merged

Use '\n'? instead of opt_nl #10051

merged 1 commit into from Feb 26, 2024

Conversation

ydah
Copy link
Contributor

@ydah ydah commented Feb 21, 2024

Change to use Parameterizing rules.

@ydah ydah marked this pull request as ready for review February 21, 2024 14:28
@nobu
Copy link
Member

nobu commented Feb 22, 2024

Maybe we should wait for lrama to implement '\n'??

BTW, why changing indents?

@ydah ydah changed the title Use option('\n') instead of opt_nl Use '\n'? instead of opt_nl Feb 22, 2024
nobu
nobu reviewed Feb 22, 2024
View reviewed changes
parse.y Outdated Show resolved Hide resolved
@ydah
Copy link
Contributor Author

ydah commented Feb 22, 2024

Maybe we should wait for lrama to implement '\n'??

I thought option (...) might be easier to understand, but '\n'? sounds good. I changed it.

BTW, why changing indents?

Oh, sorry. I put it back.

@ydah ydah requested a review from nobu February 22, 2024 14:07
@yui-knk yui-knk merged commit 89f0c0c into ruby:master Feb 26, 2024
96 checks passed
@ydah ydah deleted the use-parameterizing-rules2 branch February 26, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobu nobu nobu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@ydah @nobu @yui-knk