Migrate auto_request_review back to CODEOWNERS #10133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
k0kubun
added a commit
that referenced
this pull request
Apr 3, 2024
artur-intech
pushed a commit
to artur-intech/ruby
that referenced
this pull request
Apr 26, 2024
Revert "Migrate auto_request_review back to CODEOWNERS (ruby#10133)" This reverts commit c5b568b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We switched from CODEOWNERS to
auto_request_reviewfor sending review requests automatically because the YJIT team used to have members who don't have write access and CODEOWNERS doesn't support teams or people without write access on the repository.auto_request_reviewhas a couple of minor problems:last_files_match_onlyfeature has not been working as expected. So we currently can't excludeyjit/src/cruby_bindings.inc.rsfrom the review target.At the moment, @ruby/yjit has only committers, so we don't need to use
auto_request_review. I gave write access to @ruby/yjit so that we could use CODEOWNERS with it.Until we get a new team member, I'd like to switch this back to CODEOWNERS.