[Bug #20322] Fix rb_enc_interned_str_cstr null encoding #10169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation for `rb_enc_interned_str_cstr` notes that `enc` can be a null pointer, but this currently causes a segmentation fault when trying to autoload the encoding. This commit fixes the issue by checking for NULL before calling `rb_enc_autoload`.
Launchable Report❌ Test session #2679418 failed ❌ Test session #2679429 failed Passed test sessions✅ Test session #2679416 passed Build: refs_pull_10169_merge_039a1129ab55b887a1721baecb366998f4d05c69 |
nobu
requested changes
Mar 3, 2024
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
nobu
approved these changes
Mar 3, 2024
thomasmarshall
added a commit
to Shopify/truffleruby
that referenced
this pull request
Mar 5, 2024
This commit adds support for a null pointer to be passed as the encoding argument to rb_enc_interned_str_cstr. When we implemented this function originally, we noticed that the CRuby behavior did not match the header documentation, so we opted not to support it. However, this has now been fixed in CRuby [1], so we can fix it here as well. [1]: ruby/ruby#10169
thomasmarshall
added a commit
to Shopify/truffleruby
that referenced
this pull request
Mar 5, 2024
This commit adds support for a null pointer to be passed as the encoding argument to rb_enc_interned_str_cstr. When we implemented this function originally, we noticed that the CRuby behavior did not match the header documentation, so we opted not to support it. However, this has now been fixed in CRuby [1], so we can fix it here as well. [1]: ruby/ruby#10169
thomasmarshall
added a commit
to Shopify/truffleruby
that referenced
this pull request
Mar 6, 2024
This commit adds support for a null pointer to be passed as the encoding argument to rb_enc_interned_str_cstr. When we implemented this function originally, we noticed that the CRuby behavior did not match the header documentation, so we opted not to support it. However, this has now been fixed in CRuby [1], so we can fix it here as well. [1]: ruby/ruby#10169
thomasmarshall
added a commit
to Shopify/truffleruby
that referenced
this pull request
Mar 13, 2024
This commit adds support for a null pointer to be passed as the encoding argument to rb_enc_interned_str_cstr. When we implemented this function originally, we noticed that the CRuby behavior did not match the header documentation, so we opted not to support it. However, this has now been fixed in CRuby [1], so we can fix it here as well. [1]: ruby/ruby#10169
thomasmarshall
added a commit
to Shopify/truffleruby
that referenced
this pull request
Mar 13, 2024
This commit adds support for a null pointer to be passed as the encoding argument to rb_enc_interned_str_cstr. When we implemented this function originally, we noticed that the CRuby behavior did not match the header documentation, so we opted not to support it. However, this has now been fixed in CRuby [1], so we can fix it here as well. [1]: ruby/ruby#10169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.ruby-lang.org/issues/20322
While adding support for
rb_enc_interned_str_cstrin TruffleRuby, we noticed the documentation says thatenccan be a null pointer:ruby/include/ruby/internal/encoding/string.h
Line 120 in 93556d4
However, this currently causes a segmentation fault when it tries to autoload the encoding because it calls
rb_enc_mbmaxlenwhich expects a non-null encoding. This commit fixes the issue by checking for NULL before callingrb_enc_autoload.I'm not sure how necessary the fix is, perhaps nobody has encountered this issue. Alternatively we could just remove the note about null pointers from the docs.