[DOC] Array doc #10199
Merged
[DOC] Array doc #10199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There may be too many examples in the new section; suggest deletions please. |
|
I think the doc for Array#[]= may be missing the cases where the operand is an array; if so, that will be for a different PR. |
| @@ -2284,6 +2294,73 @@ ary_aset_by_rb_ary_splice(VALUE ary, long beg, long len, VALUE val) | |||
| * | |||
| * Assigns elements in +self+; returns the given +object+. | |||
| * | |||
| * In brief: | |||
There was a problem hiding this comment.
IMO the "in brief" section stops being useful when it tries to exhaustively cover all the cases. It becomes harder to read than the regular documentation.
|
@peterzhu2118, will you be reviewing this? I've pared down the examples (as I suggested in the OP might be necessary). |
peterzhu2118
approved these changes
Mar 13, 2024
|
Sorry, I must have missed this. |
artur-intech
pushed a commit
to artur-intech/ruby
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds section 'In brief' for Array#[]=.