Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature #20275] Remove extra backtrace entries for rescue and ensure #10325

Merged
merged 1 commit into from
Mar 22, 2024
Merged

[Feature #20275] Remove extra backtrace entries for rescue and ensure #10325

merged 1 commit into from
Mar 22, 2024

Conversation

eregon
Copy link
Member

@eregon eregon commented Mar 21, 2024

@eregon eregon requested a review from mame March 21, 2024 20:07
@launchable-app Launchable app

This comment has been minimized.

Sign in to view
@mame
Copy link
Member

mame commented Mar 22, 2024

Please fix the test failure. If it's easily fixed, it looks fine. Thanks!

@eregon eregon force-pushed the remove-extra-backtrace-entry-rescue-ensure branch from 005facd to 61e9704 Compare March 22, 2024 10:57
@eregon
Copy link
Member Author

eregon commented Mar 22, 2024

I missed a change in test/ruby/test_backtrace.rb, done now, it's a trivial one line change (removing the old rescue in line, as expected).

@eregon eregon enabled auto-merge (rebase) March 22, 2024 11:18
@eregon eregon merged commit 74995a1 into ruby:master Mar 22, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mame mame Awaiting requested review from mame

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@eregon @mame