New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support warning feature for bundled gems with bootsnap and zeitwerk #10347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@fxn @byroot This version warn correctly with Zeitwerk and Bootsnap
|
hsbt
added a commit
to hsbt/ruby
that referenced
this pull request
Mar 25, 2024
Fix incorrect warning target with Zeitwerk and support warning with Bootsnap.
casperisfine
pushed a commit
to Shopify/ruby
that referenced
this pull request
Mar 25, 2024
Followup: ruby#10347 This avoid directly referencing bootsnap and zeitwerk, and also handle other gems that may decorate `require`.
Thanks @hsbt! |
hsbt
pushed a commit
that referenced
this pull request
Mar 25, 2024
Followup: #10347 This avoid directly referencing bootsnap and zeitwerk, and also handle other gems that may decorate `require`.
hsbt
pushed a commit
to hsbt/ruby
that referenced
this pull request
Mar 25, 2024
Followup: ruby#10347 This avoid directly referencing bootsnap and zeitwerk, and also handle other gems that may decorate `require`.
hsbt
pushed a commit
to hsbt/ruby
that referenced
this pull request
Mar 25, 2024
Followup: ruby#10347 This avoid directly referencing bootsnap and zeitwerk, and also handle other gems that may decorate `require`.
hsbt
pushed a commit
to hsbt/ruby
that referenced
this pull request
Apr 16, 2024
Followup: ruby#10347 This avoid directly referencing bootsnap and zeitwerk, and also handle other gems that may decorate `require`.
jhawthorn
added a commit
to github/ruby
that referenced
this pull request
Apr 23, 2024
This reverts commit 2f65458.
FYI, I'm not sure this is totally working as intended. We're using bootsnap and previously had no issues with 3.3.0, but upon updating to 3.3.1, now seeing this:
|
@mscrivo Can you file your Gemfile and environment to https://bugs.ruby-lang.org/issues/20450? |
artur-intech
pushed a commit
to artur-intech/ruby
that referenced
this pull request
Apr 26, 2024
Followup: ruby#10347 This avoid directly referencing bootsnap and zeitwerk, and also handle other gems that may decorate `require`.
hsbt
pushed a commit
to hsbt/ruby
that referenced
this pull request
Apr 30, 2024
Followup: ruby#10347 This avoid directly referencing bootsnap and zeitwerk, and also handle other gems that may decorate `require`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some fixes from #10244