Refactor live and garbage obj check #10359
Open
+14
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
eileencodes
force-pushed
the
refactor-live-and-garbage-obj-check
branch
2 times, most recently
from
0258a4b
to
ea84c29
Compare
This PR moves the code for `is_live_object` into `is_garbage_object` because they are opposite of one another. It also replaces calls to `is_live_object` and `rb_objspace_markable_object_p` with `!is_garbage_object` and `!rb_objspace_garbage_object_p` respectively. This refactor reduces the surface area of the GC API. Co-authored-by: Peter Zhu <peter@peterzhu.ca>
eileencodes
force-pushed
the
refactor-live-and-garbage-obj-check
branch
from
ea84c29
to
54484ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the code for
is_live_objectintois_garbage_objectbecause they are opposite of one another. It also replaces calls tois_live_objectandrb_objspace_markable_object_pwith!is_garbage_objectand!rb_objspace_garbage_object_prespectively.This refactor reduces the surface area of the GC API.