YJIT: Let sp_opnd take the number of slots #10442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XrXr
approved these changes
Apr 3, 2024
artur-intech
pushed a commit
to artur-intech/ruby
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the interface of
ctx.sp_opnd().For most of the time,
ctx.sp_opndtakessomething * SIZEOF_VALUE. It seems tedious to repeat* SIZEOF_VALUEeverywhere. It needs to take the number of bytes whenRUBY_SIZEOF_CONTROL_FRAMEis used for stack overflow checks, but it's a multiple ofSIZEOF_VALUEtoo.Statically asserting
RUBY_SIZEOF_CONTROL_FRAME % SIZEOF_VALUE == 0, which seems like a fair assumption, we should be able to safely change the interface to take the number ofVALUEslots.