Enumerator should use a non-blocking fiber, change rb_fiber_new to be non-blocking by default.
#10481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
enumerator-nonblocking
branch
from
f3370e0
to
d795dfa
Compare
|
This changes |
|
I disabled the auto-merge since this incompatibility seems worth thinking about before merging. |
|
Can you show where it's incompatible? |
|
If it's already the behavior of Fiber.new then it sounds fair to change rb_fiber_new() too (which should have been changed at the same time ideally). |
ioquatix
changed the title
rb_fiber_new to be non-blocking by default.
|
Appreciate the review. |
artur-intech
pushed a commit
to artur-intech/ruby
that referenced
this pull request
Apr 26, 2024
…be non-blocking by default. (ruby#10481)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-applies #10478 sans the
parse.hchange.