Use ruby_thread_set_pthread_native at boot #10491
Open
+17
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At boot, `th->ractor->threads.running_ec == th->ec` is true, so calling ruby_thread_set_native will cause an assertion error. ``` Assertion Failed: ractor_core.h:328:rb_ractor_set_current_ec_:ec == ((void*)0) || cr->threads.running_ec != ec -- C level backtrace information ------------------------------------------- miniruby(rb_vm_bugreport+0xb60) [0x100290f20] vm_dump.c:1151 miniruby(rb_vm_bugreport) (null):0 miniruby(rb_assert_failure_detail+0xa4) [0x1003b533c] error.c:1168 miniruby(rb_assert_failure_detail+0x0) [0x1003b5298] error.c:1148 miniruby(rb_assert_failure) (null):0 miniruby(Init_native_thread.cold.1+0x0) [0x1003d3c24] ractor_core.h:328 miniruby(rb_ractor_set_current_ec_) (null):0 miniruby(ruby_thread_set_native.cold.1) thread_pthread.c:1624 miniruby(Init_native_thread+0x0) [0x100222380] ractor_core.h:328 miniruby(ruby_thread_set_native) (null):0 miniruby(fiber_entry+0x1c) [0x10008a1c4] cont.c:845 miniruby(coroutine_trampoline+0xa8) [0x1003a1d78] coroutine/pthread/Context.c:148 /usr/lib/system/libsystem_pthread.dylib(_pthread_start+0x88) [0x1911fef94] ```
peterzhu2118
force-pushed
the
set-pthread-native
branch
from
72c1b80
to
a0735c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At boot,
th->ractor->threads.running_ec == th->ecis true, so calling ruby_thread_set_native will cause an assertion error.