Use unsigned long long for object ID #10551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since unsigned long long are minumum 64 bits, we have at least 10**17 object IDs available, so there is no chance it will overflow.
peterzhu2118
force-pushed
the
long-long-obj-id
branch
from
3c3e350
to
8d23b40
Compare
peterzhu2118
changed the title
|
It is very unlikely, but not "no chance". |
nobu
reviewed
Apr 16, 2024
| id = objspace->next_object_id; | ||
| objspace->next_object_id = rb_int_plus(id, INT2FIX(OBJ_ID_INCREMENT)); | ||
| id = ULL2NUM(objspace->next_object_id); | ||
| objspace->next_object_id += OBJ_ID_INCREMENT; |
There was a problem hiding this comment.
I don't think it's necessary. If we allocated 1000 object IDs every millisecond (i.e. 1,000,000 per second), it would take 15,000 years for it to overflow.
(((2**64) / 40) / ((1000 * 60 * 60 * 24) * 1000)) / 365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since unsigned long long are minumum 64 bits, we have at least 10**17 object IDs available, so there is no chance it will overflow.