Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YJIT: Fix canary crash with Array#<< #10568

Merged
merged 1 commit into from Apr 18, 2024
Merged

Conversation

XrXr
Copy link
Member

@XrXr XrXr commented Apr 17, 2024

Previously, we got "We are killing the stack canary set by opt_ltlt"
from $./miniruby --yjit-call-threshold=1 -e 'a = [].freeze; a << 1'

Found by running ruby-spec with yjit-call-threshold=1.

Previously, we got "We are killing the stack canary set by opt_ltlt"
from `$./miniruby --yjit-call-threshold=1 -e 'a = [].freeze; a << 1'`

Found by running ruby-spec with yjit-call-threshold=1.
@matzbot matzbot requested a review from a team April 17, 2024 21:11
Copy link
Member

@k0kubun k0kubun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maximecb maximecb merged commit 28efc0c into ruby:master Apr 18, 2024
101 checks passed
@XrXr XrXr deleted the yjit-ary-push-non-leaf branch April 18, 2024 16:59
artur-intech pushed a commit to artur-intech/ruby that referenced this pull request Apr 26, 2024
Previously, we got "We are killing the stack canary set by opt_ltlt"
from `$./miniruby --yjit-call-threshold=1 -e 'a = [].freeze; a << 1'`

Found by running ruby-spec with yjit-call-threshold=1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants