Refer autoconfigured endian macro #10572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the case `RB_IO_BUFFER_HOST_ENDIAN` is not defined.
ioquatix
approved these changes
Apr 18, 2024
|
|
|
Does every windows build use autoconf? |
|
Windows builds do not use autoconf, then |
So |
artur-intech
pushed a commit
to artur-intech/ruby
that referenced
this pull request
Apr 26, 2024
Remove the case `RB_IO_BUFFER_HOST_ENDIAN` is not defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the case
RB_IO_BUFFER_HOST_ENDIANis not defined.REG_DWORDon Windows is unconditionally equal toREG_DWORD_LITTLE_ENDIAN, which probably would have been added for symmetry withREG_DWORD_BIG_ENDIANnot for portability.