YJIT: Optimize local variables when EP == BP (take 2) #10607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
force-pushed
the
yjit-ep-bp
branch
2 times, most recently
from
4ce01ec
to
ac61272
Compare
k0kubun
changed the title
Co-authored-by: Alan Wu <alansi.xingwu@shopify.com>
artur-intech
pushed a commit
to artur-intech/ruby
that referenced
this pull request
Apr 26, 2024
* Revert "Revert "YJIT: Optimize local variables when EP == BP" (ruby#10584)" This reverts commit c878344. * YJIT: Take care of GC references in ISEQ invariants Co-authored-by: Alan Wu <alansi.xingwu@shopify.com> --------- Co-authored-by: Alan Wu <alansi.xingwu@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the revert of #10487.
Alan discovered that we don't mark ISEQs in
no_ep_escape_iseqs, which can lead to missing invalidation and code generation with a wrong assumption afterGC.compact. This PR fixes the problem by updating ISEQ references onrb_yjit_iseq_update_references. It also frees ISEQ keys onrb_yjit_iseq_free.