Change return value of gets function to be rb_parser_string_t * instead of VALUE
#10631
+35
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yui-knk
force-pushed
the
rb_parser_lex_gets_func_returns_rb_parser_string_t_ptr
branch
from
2e65e81
to
e6144fd
Compare
…nstead of `VALUE` This change reduces parser's dependency on ruby object.
yui-knk
force-pushed
the
rb_parser_lex_gets_func_returns_rb_parser_string_t_ptr
branch
from
e6144fd
to
d86e584
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reduces parser's dependency on ruby object.