Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use user defined parameterizing rules opt_args_tail(tail) #10667

Merged
merged 1 commit into from May 1, 2024

Conversation

ydah
Copy link
Contributor

@ydah ydah commented Apr 29, 2024

No description provided.

@ydah ydah force-pushed the use-user-defined-parameterizing-rules-2 branch 2 times, most recently from 0732b4c to 2fa1d58 Compare April 29, 2024 01:22
@ydah ydah force-pushed the use-user-defined-parameterizing-rules-2 branch from 2fa1d58 to 25ca8b3 Compare April 29, 2024 01:31
@yui-knk
Copy link
Contributor

yui-knk commented May 1, 2024

@ydah JFYI:
I get feedback from @nobu. nobu suggests it's good if we can reduce redundant <node_args> specification on caller side. I think it might be possible to introduce new Lrama grammar file syntax to support default LHS type specifier on %rule definition like below, which will be overridden caller side tag specification.
As a fact, all these 3 PRs use same tag

%rule opt_args_tail(tail) <node_args>: ',' tail { ... } ...

@yui-knk yui-knk merged commit 9f7e0d2 into ruby:master May 1, 2024
100 checks passed
@ydah ydah deleted the use-user-defined-parameterizing-rules-2 branch May 1, 2024 05:03
@yui-knk
Copy link
Contributor

yui-knk commented May 2, 2024

#10706 removes redundant <tag> specifications on caller side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants