Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport commit for ruby_3_2 [Bugs #19753] #10778

Merged
merged 4 commits into from
May 18, 2024

Conversation

nagachika
Copy link
Member

@nagachika nagachika commented May 16, 2024

Backport PR for https://bugs.ruby-lang.org/issues/19753.
This includes some preceding refactoring commits to resolve conflicts.

nobu and others added 4 commits May 16, 2024 20:44
)

- Fix IO::Buffer `read`/`write` to use a minimum length.
* Fix `io_buffer_get_string` default length computation.

When an offset bigger than the size is given, the resulting length will be
computed incorrectly. Raise an argument error in this case.

* Validate all arguments.
@nagachika nagachika marked this pull request as ready for review May 16, 2024 12:05
@matzbot matzbot requested a review from a team May 16, 2024 12:05
Copy link
Member

@ioquatix ioquatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your effort.

@nagachika nagachika merged commit 0e664eb into ruby:ruby_3_2 May 18, 2024
80 of 82 checks passed
@nagachika nagachika deleted the bugs_19753 branch May 18, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants