Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DOTQ to ANDDOT #1090

Conversation

aleksandrs-ledovskis
Copy link

Switch internal/token name to reflect current form of safe-call operator

/cc @nobu

@hsbt
Copy link
Member

hsbt commented Nov 10, 2015

looks good, travis fails are unrelated failures with this pull requests.

@nobu Do you think about this?

@aleksandrs-ledovskis aleksandrs-ledovskis force-pushed the feature/rename-dotq-to-anddot branch 2 times, most recently from 93b872f to daae27a Compare November 10, 2015 07:42
Switch internal VM/token name to reflect current form of safe-call operator.

Follows 837babd

Signed-off-by: Aleksandrs Ļedovskis <aleksandrs@ledovskis.lv>
@aleksandrs-ledovskis
Copy link
Author

Rebased against latest trunk. After couple of tries, build finally have succeeded.

@nobu
Copy link
Member

nobu commented Nov 10, 2015

I've thought about the name in these days, ADOT, ANDOT, ANDDOT, QDOT, etc.
ANDDOT may be good enough.

@nobu nobu closed this in a01b645 Nov 10, 2015
@aleksandrs-ledovskis aleksandrs-ledovskis deleted the feature/rename-dotq-to-anddot branch November 10, 2015 10:00
sonots pushed a commit to sonots/ruby that referenced this pull request Nov 17, 2015
* defs/id.def, parse.y: Switch internal token name to reflect
  current form of safe-call operator.  [Fix rubyGH-1090]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52525 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants