check SPEC_TEMP_DIR is world-writable or not
#10961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` 1) Dir.mktmpdir when passed a block yields the path to the passed block ERROR ArgumentError: parent directory is world writable but not sticky: /tmp/rubytest.wlu5cs_11 /tmp/ruby/src/trunk/lib/tmpdir.rb:113:in 'Dir.mktmpdir' /tmp/ruby/src/trunk/spec/ruby/library/tmpdir/dir/mktmpdir_spec.rb:39:in 'block (2 levels) in <top (required)>' ``` This weird error comes from world-writable (and not sticky) directory of `SPEC_TEMP_DIR`. This patch checks `SPEC_TEMP_DIR` is not world-writable if exists and `File.umask` contains o+w mask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This weird error comes from world-writable (and not sticky) directory of
SPEC_TEMP_DIR.This patch checks
SPEC_TEMP_DIRis not world-writable if exists andFile.umaskcontains o+w mask.